search

towhee-io / towhee

Towhee is a framework that is dedicated to making neural data processing pipelines simple and fast.
https://towhee.io
Apache License 2.0
3.16k stars 246 forks source link

fix issue 2674 - enable towhee to work with pydantic 2.5.x #2675

Closed dove-young closed 8 months ago

dove-young commented 9 months ago 
pydantic                 2.5.1
pydantic_core            2.14.3

Fix issue https://github.com/towhee-io/towhee/issues/2674

Fix issue https://github.com/towhee-io/towhee/issues/2676

sre-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dove-young To complete the pull request process, please assign fzliu after the PR has been reviewed. You can assign the PR to them by writing /assign @fzliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/towhee-io/towhee/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sre-ci-robot commented 9 months ago

Welcome @dove-young! It looks like this is your first PR to towhee-io/towhee 🎉

junjiejiangjjj commented 9 months ago

Very tks for this pr, however, this change does not work in environments with pydantic<2. If you want to modify it, you need to make sure it works in both pydantic 1.x and 2.x.

stale[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Close the stale issues and pull requests after 7 days of inactivity. Reopen the issue with /reopen.