search

tox-dev / filelock

A platform-independent file lock for Python.
https://py-filelock.readthedocs.io
The Unlicense
760 stars 107 forks source link

Hotfix: Restore __init__ method; more robust initialization for singleton locks #338

Closed ethanbb closed 4 months ago

ethanbb commented 4 months ago

Fixes issue with subclassing brought up in pypa/virtualenv#2735 (discussed in #334)

ethanbb commented 4 months ago

Will add a test for this as well.

ethanbb commented 4 months ago

Sorry for this mess. I understand if you want to take longer to review this time; did not realize so much infrastructure relies on this package.

gaborbernat commented 4 months ago

Sorry for this mess. I understand if you want to take longer to review this time; did not realize so much infrastructure relies on this package.

No worries All good.

ethanbb commented 4 months ago

I had this test failure on test_singleton_locks_are_deleted_when_no_external_references_exist when testing locally as well and couldn't figure out what was wrong. Anyone have an idea?

ethanbb commented 4 months ago

I had this test failure on test_singleton_locks_are_deleted_when_no_external_references_exist when testing locally as well and couldn't figure out what was wrong. Anyone have an idea?

Never mind, got it