tox-dev / pipdeptree

A command line utility to display dependency tree of the installed Python packages
https://pypi.python.org/pypi/pipdeptree
MIT License
2.79k stars 150 forks source link

Have duplicate metadata and invalid req strings honor --warn option #357

Closed kemzeb closed 5 months ago

kemzeb commented 5 months ago

This resolves #355 by making changes and refactors to the warning logic. It does so by introducing a module-level singleton "WarningPrinter" object and refactors the code in such a way to integrate this object for it to be used.

kemzeb commented 5 months ago

Still working on this, I'll see if I can finish this and open it for review by the end of today.

kemzeb commented 5 months ago

Did a redesign and this seems to be a better implementation than the last. Just need to add coverage tests then I'll open this PR for review

kemzeb commented 5 months ago

I think this is ready to go, going to open this for review

kemzeb commented 5 months ago

Here are my design decisions:

xiacunshun commented 5 months ago

Ignore my previous deleted comment, I've reconsidered and the handling of "duplicated" here should be fine.

xiacunshun commented 5 months ago

No questions for me here. But I don't have the approve auth, so maybe need to wait for @gaborbernat to take a further look.

kemzeb commented 5 months ago

Great, will release 2.19.0 after merging this