tox-dev / platformdirs

A small Python module for determining appropriate platform-specific dirs, e.g. a "user data dir".
https://platformdirs.readthedocs.io
MIT License
593 stars 51 forks source link

Speed up Hatch installation #282

Closed ofek closed 5 months ago

ofek commented 5 months ago

This is the new way, speedup on Windows ~35-50%, other platforms 2-3x

gaborbernat commented 5 months ago

It seems that it is not working.

ofek commented 5 months ago

Yeah, figuring out the best way to fix Windows. I can't just do ./main.sh because that is in the directory where the action is checked out so you must do a full path. When the shell is bash the backslashes aren't treated literally and therefore get stripped which makes it so the full path doesn't exist. When the shell is not specified it works because then Windows uses PowerShell but every step of an action requires an explicit shell... so might have to have 2 steps that are conditional based on the platform because you cannot use conditional syntax within the shell value. Nightmare.

ofek commented 5 months ago
ofek commented 5 months ago

Everything is fixed now, thanks for your patience!