search

tox-dev / tox-conda

Make tox cooperate with conda envs
MIT License
152 stars 40 forks source link

tox4 support #156

Open deepyaman opened 1 year ago

deepyaman commented 1 year ago

Will tox-conda support tox4? I see that there's a tox-4 branch, but it's almost 100 commits behind master/doesn't look maintained.

AntoineD commented 1 year ago

tox4 will be supported, but for now I cannot give a better estimation than during 2023...

deepyaman commented 1 year ago

@AntoineD Thanks for the very quick reply! Maybe we'll stick to tox3 for the time being then, and keep an eye on this.

tibortakacs commented 1 year ago

@AntoineD As part of my project's custom tox plugin, I have finished a tox4 plugin with conda support. I am happy to adjust it to make general and be part of this repository. I am not saying that it will immediately cover all features tox-conda already has, but I believe it covers the main use cases and could be the foundation of further works for tox4 support. It uses conda run instead of activation, it creates a conda ToxEnv, so using only one plugin (register new tox env) hook was enough. Would you consider this as a contribution in tox-conda?

AntoineD commented 1 year ago

@tibortakacs Could you please create a PR so we can have a look?

tibortakacs commented 1 year ago

@AntoineD Of course, happy to. Due to other commitments, it will take some time, I try to make it in two weeks.

tibortakacs commented 1 year ago

@AntoineD I have been working on this right now. You can track the progress here: https://github.com/tibortakacs/tox-conda/tree/tox4 I hope I can create a draft PR this week that shows the basic design principles. This can be used as a base of further discussion and work.

tibortakacs commented 1 year ago

Please find the draft PR here: https://github.com/tox-dev/tox-conda/pull/163 (This is based on this branch: https://github.com/tibortakacs/tox-conda/tree/tox4)

The main purpose is to agree on the direction, and once there is a common agreement, this PR can be improved by updating the tests and hitting the module hard to find and fix bugs. I have tested with the basic functionalities, it works fine, but I am sure that there are use cases that this PR does not cover yet.

Looking forward to your feedback.

tibortakacs commented 1 year ago

@gaborbernat Do you have any suggestion how we can move forward? It might be a good step to use the tox4 branch, merge this in, and gradually do the improvements and testing. We can also create pre-release package using it.

gaborbernat commented 1 year ago

Sure, I think ultimately blocked this on the maintainer (not me) to take it up.

tibortakacs commented 1 year ago

Thank you, @gaborbernat. (The PR is automatically assigned to you, I thought you are the one to make decision in this regard.) I will wait for the maintainers' feedback.

millsks commented 1 year ago

Is there an update on tox-conda supporting tox4?

tibortakacs commented 1 year ago

Is there an update on tox-conda supporting tox4?

Yes, please find the PR here: https://github.com/tox-dev/tox-conda/pull/163

You can use the merging branch for now, it works fully. I hope I can find time soon to finish off the PR, and merge it back to main. Any early feedback is highly appreciated.