search

tox-dev / tox-pipenv

A pipenv plugin for Tox
MIT License
124 stars 30 forks source link

Find a better alternative to the use of environment variables #35

Closed tonybaloney closed 6 years ago

tonybaloney commented 6 years ago

The plugin relies heavily on Pipenv's environment variables, since at the time of development (v9) the settings for Pipenv were in the global scope, they were loaded into the module at import. See https://github.com/tox-dev/tox-pipenv/blob/master/tox_pipenv/plugin.py If Pipenv changes to be an importable library instead of designed as a shell, this could change.

@kennethreitz if you have any thoughts on the right approach?

kennethreitz commented 6 years ago

I think that tox-pipenv is a bit hacky, but it looks like it'll "get the job done" for most people — kind of like tox itself :)

kennethreitz commented 6 years ago

We have no plans to library-ize, at this time. I think what you're doing is appropriate (and similar to what we're doing within our own test suite). That's the expected API.