search

tox-dev / tox-pipenv

A pipenv plugin for Tox
MIT License
124 stars 30 forks source link

Fix issues with `venv` object for tox>=3.8.0 (on py36) #62

Closed chiqomar closed 4 years ago

chiqomar commented 5 years ago

I don't know if the tests work, but the code is working properly on my machine now, python 3.6.8.

thomaslee commented 5 years ago

Ran into what I believe is the same issue on Python 3.7.3:

... snip ...
  File "/Users/tom/.local/share/virtualenvs/tools-YTG8DW9i/lib/python3.7/site-packages/tox_pipenv/plugin.py", line 164, in tox_runenvreport
    pipfile_path = _clone_pipfile(venv)
  File "/Users/tom/.local/share/virtualenvs/tools-YTG8DW9i/lib/python3.7/site-packages/tox_pipenv/plugin.py", line 22, in _clone_pipfile
    root_pipfile_path = venv.session.config.toxinidir.join("Pipfile")
AttributeError: 'VirtualEnv' object has no attribute 'session'

Haven't had a chance to verify @chiqomar's attempted fix yet.

uhurusurfa commented 4 years ago

@tonybaloney @AlmogCohen Any chance this can be reviewed and moved forward? I tested the fix and works fine (minus the line 37 change in plugin.py - the original works for me with tox 3.14)

gaborbernat commented 4 years ago

Superseded by #66