search

tox-dev / tox-uv

Use https://github.com/astral-sh/uv with tox
MIT License
66 stars 14 forks source link

fix(venv): respect base_python passed as absolute path #69

Closed paveldikov closed 1 month ago

paveldikov commented 1 month ago

Fixes: tox-dev/tox#3191

© 2024 Morgan Stanley.

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE APACHE LICENSE V.2.0.

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

paveldikov commented 1 month ago

@gaborbernat bumping just in case this got lost in transit. I've edited my change to call out to interpreter to mine info for PythonInfo tuple. Can you please re-review?

paveldikov commented 1 month ago

Thanks for the approval! A few conversations are still unresolved (I think they're pretty unambiguous, but I will let you decide)

gaborbernat commented 1 month ago

CI not green 😁

paveldikov commented 1 month ago

D'oh! This caught an actual bug -- would have been impossible to specify an alternate Python installation of the same major/minor version.

I'm doing these fixes on my phone so apologies for the back-and-forth (I can't run the test suite locally). If it keeps failing I'll have a 'proper' look at it tonight

gaborbernat commented 1 month ago

check / test 3.8 on windows-latest (pull_request) Failing after 1m ...

paveldikov commented 1 month ago

check / test 3.8 on windows-latest (pull_request) Failing after 1m ...

Amended. Hoping that's it...

P.S. perhaps too little too late for this one, but is there a way I can trigger CI on my own? Would have spared us a lot of the to'ing and fro'ing :-P

paveldikov commented 1 month ago

@gaborbernat bumping :-)