search

tox-rs / rstox

Rust bindings to c-toxcore
GNU General Public License v3.0
16 stars 7 forks source link

[WIP] new A/V API #17

Closed zetok closed 8 years ago

zetok commented 9 years ago

Do not merge yet.

currently only low-level binding is ~done. Safe interface is yet to be written.

Depends on https://github.com/irungentoo/toxcore/pull/1375.

I could make use of some feedback, and perhaps help - I'll see to writing safe interface, but given that I will be doing that for the first time, I don't know how well that will turn out ;)

quininer commented 8 years ago

Any news about this?

zetok commented 8 years ago

Any news about this?

I kinda have given up on doing it - sorry about that - limited time + knowledge about unsafe Rust is currently a bit of a showstopper.

Given limited time that I can spend on things, I think that rather than binding, I should put an effort to rewrite toxcore in pure Rust - I don't really have anything real as of yet, and it will take me at least months to rewrite toxcore in Rust.

As for this PR - low level (unsafe) binding to C is ~done, what is left is safe interface.

quininer commented 8 years ago

oh, I look forward to it. ;)

quininer commented 8 years ago

I try to finish it, now the audio is working. https://github.com/quininer/rstox/blob/newav/examples/testav.rs

suhr commented 8 years ago

(read the code a bit) What happens when Tox is destroyed before ToxAV?

quininer commented 8 years ago

@suhr Probably will can't compile?

suhr commented 8 years ago

Well, ToxAV doesn't seem to be bound with Tox, so it should compile.

zetok commented 8 years ago

Well, it kinda works, and IMHO is sufficient for merge, given that current master's support for A/V is completely broken.