search

tox-rs / rstox

Rust bindings to c-toxcore
GNU General Public License v3.0
16 stars 7 forks source link

Add a method to disable LAN in tox options #41

Closed JFreegman closed 3 years ago

JFreegman commented 3 years ago

Also fixed the setter functions so that you can actually use them.

kpp commented 3 years ago

@suhr can have his own vision on which pattern for setters to use. Let's wait on his review.

JFreegman commented 3 years ago

@suhr can have his own vision on which pattern for setters to use. Let's wait on his review.

I couldn't get it to compile, so I just wrote it in what I consider to be a simpler way. I don't get why you would want it to return itself and why it doesn't pass self by reference.

Edit: Nevermind I just figured it out, updated PR.