search

tox4j / deprecated-tox4j

Deprecated, see http://github.com/TokTok/jvm-toxcore-c
http://github.com/TokTok/jvm-toxcore-c
Other
42 stars 17 forks source link

Add GroupNameListChangeCallback, minor changes in ToxSimpleChat #13

Closed sk8ter closed 9 years ago

sonOfRa commented 9 years ago

Java methods shouldn't return the error codes that native methods return. They only return the friendNumber/groupnumber. In case a failure happens, an exception should be thrown, rather than passing an error code to the caller.

sk8ter commented 9 years ago

I will remember this for future.

sk8ter commented 9 years ago

Could you please cherry pick my commits and merge to master. Looks like I have managed to rebase to new branch (sk8ter:groupchat), but can not push it to sk8ter:master.

sonOfRa commented 9 years ago

I cherry-picked the relevant commits into master. You should now reset your master branch to my master branch, and branch any new work off there.