search

tox4j / deprecated-tox4j

Deprecated, see http://github.com/TokTok/jvm-toxcore-c
http://github.com/TokTok/jvm-toxcore-c
Other
42 stars 17 forks source link

Scala conversion #68

Closed iphydf closed 9 years ago

sonOfRa commented 9 years ago

A lot of files don't have newlines at the end of them. For consistency, we might want to have a newline at the end of every file, or at the end of no file. I'm leaning towards newline at the end of all files (better diffs when the last line changes).

sonOfRa commented 9 years ago

@toxbot try

ghost commented 9 years ago

:hourglass: Trying commit 64e9962 with merge 73d046f...

ghost commented 9 years ago

:sunny: Test successful - travis

sonOfRa commented 9 years ago

Testing updated_at

sonOfRa commented 9 years ago

@iphydf src/main/scala/im/tox/client/ToxClient.scala → src/main/java/im/tox/tox4j/client/ToxClient.scala This file move makes the package declaration in ToxClient.scala incorrect (it's sitting in im/tox/tox4j/client, but the package is im.tox.client

iphydf commented 9 years ago

Re: EOLs: fixed. Re: file move: that was wrong, moved it to the correct directory now.

iphydf commented 9 years ago

@toxbot try

ghost commented 9 years ago

:hourglass: Trying commit 16886cd with merge 156257f...

ghost commented 9 years ago

:sunny: Test successful - travis

sonOfRa commented 9 years ago

@toxbot r+ 156257f

ghost commented 9 years ago

:scream_cat: 156257f is not a valid commit SHA. Please try again with 2d7aa84.

sonOfRa commented 9 years ago

@toxbot r+ 2d7aa84

ghost commented 9 years ago

:hourglass: Testing commit 2d7aa84 with merge 17ae625...

ghost commented 9 years ago

:sunny: Test successful - travis