tox4j / deprecated-tox4j

Deprecated, see http://github.com/TokTok/jvm-toxcore-c
http://github.com/TokTok/jvm-toxcore-c
Other
42 stars 17 forks source link

Fetch protoc binaries from maven #80

Open Flakebi opened 9 years ago

Flakebi commented 9 years ago

At the moment the build system needs installed protoc binaries in $PATH and they have to be the same version as protobuf-java (fetched automatically by sbt). There is a maven repository (https://repo1.maven.org/maven2/com/google/protobuf/protoc/) that can be used to fetch a specific protoc version with sbt.

iphydf commented 9 years ago

Good idea but unfortunately this turns out to be almost useless. Even if we have protoc, we still need the protobuf C++ library of the right version. I suppose we could check pkgconfig for the library version and then fetch the right protoc.

iphydf commented 9 years ago

This one is up for grabs. I don't have time or priority to work on this now.

iphydf commented 8 years ago

This is done in https://github.com/iphydf/tox4j/commit/dc8a38741fb4113306647c1019c1b5f671423ec7. When it goes into tox4j/master, I will close this issue.

iphydf commented 8 years ago

By the way, we now require protobuf 3.0.0, because I was getting tired of compatibility issues on our various supported platforms. This means that most likely tox4j will no longer build with your system-installed libprotobuf, so you will need to install from git.