search

toy / image_optim

Optimize images using multiple utilities
https://github.com/toy/image_optim
MIT License
1.52k stars 109 forks source link

add libjpeg-dev to install instructions #116

Closed acrogenesis closed 3 years ago

acrogenesis commented 8 years ago

I was missing libjpeg-dev on a fresh install of ubuntu 14.04

toy commented 8 years ago

Hey Adrian,

Thanks for contribution. Do you need it for building jpeg-recompress? Could you please place it so it is ordered alphabetically as other package names?

acrogenesis commented 8 years ago

@toy I really don't remember which one asked me libjpeg-dev to build.. I've already placed it alphabetically ordered.

toy commented 8 years ago

@acrogenesis After running the original apt-get command on a fresh ubuntu 14.04 leaves me with pngout and svgo not installed, but both they don't need libjpeg-dev. Even jpeg-recompress doesn't depend on it.

acrogenesis commented 8 years ago

I started a new droplet on DigitalOcean after running sudo apt-get install -y advancecomp gifsicle jhead jpegoptim libjpeg-progs optipng pngcrush pngquant and trying to install jpegoptim it say's: Cannot find libjpeg or you have too old version (v6 or later required).

Installing libjpeg-dev solves it.

screen shot 2015-12-10 at 4 43 08 pm
toy commented 8 years ago

But you are compiling jpegoptim, the apt-get command is for installing prebuilt binaries. So libjpeg-progs provides jpegtran, but libjpeg-dev is only needed to compile binaries. Also I've noticed that lots of binaries provided through apt-get are outdated, so I suggest to use image_optim_pack as you are on linux.

oblakeerickson commented 3 years ago

Just doing a little housekeeping... I think we can close this PR? It's quite old and libjpeg-dev doesn't appear to be required.

Just for reference the Discourse install guide which uses image_optim and installs many apt based packages does not need the libjpeg-dev package when installing jpegoptim.

acrogenesis commented 3 years ago

Thanks for this great project 👍