search

toybox-rs / Toybox

The Machine Learning Toybox for testing the behavior of autonomous agents.
http://toybox.rs
27 stars 12 forks source link

BaseMixin domain intervention support with decoders #179

Closed kclary closed 3 years ago

kclary commented 3 years ago

Starting a discussion about adding the features on this branch to master/main (#178). domains-amidar is a branch off domains, we can start with a pull request into that branch if that's a better first step.

I've updated some BaseMixins in Amidar. It's not clear which pieces are needed for all games. Is there an object-based test we can apply?

kclary commented 3 years ago

~Travis~ gh-actions check.sh failed:

ImportError: cannot import name 'AbstractContextManager'

AbstractContextManager was added in Python 3.6 - will need to update ~Travis~ gh-actions yaml

kclary commented 3 years ago

On tests for the BaseMixins - How do you know when to add a decode, __repr__, __str__ method to a BaseMixins object vs when the context manager will do its magic without help? Maybe that is what #152 is asking?

kclary commented 3 years ago

gh-actions CI failed due to #174. I don't understand this error, looks like the unit tests passed?

kclary commented 3 years ago

gh-actions build is crying somewhere and won't say what is wrong

jjfiv commented 3 years ago

I can't find any info anywhere, but maybe we ran out of free hours? We had a bunch that ran until the 6-hour limit hit...

kclary commented 3 years ago

@jjfiv is ok to merge, we'll see if that helps actions come back to us