Small fixes - Githubissues

toybox-rs / Toybox

The Machine Learning Toybox for testing the behavior of autonomous agents.

http://toybox.rs

27 stars 12 forks source link

Small fixes #187

Closed kclary closed 3 years ago

kclary commented 3 years ago

After a quick glance over, I'd like someone to check

[x] changes to sklearn - I kept it in the requirements but moved the import to the only function where it's used
[x] I added back some of the gym/turtle utils that were bombed out when we removed baselines

kclary commented 3 years ago

I like that addition/rename for get_turtle. _reset_deep_kludge could also do with a name change as well...though I don't think that was actually used in any of my recent stuff, so maybe we just yank that out again. I don't recall the specifics for what that function was handling anyway

etosch commented 3 years ago

@jjfiv gave me a hard time about merging this before the discussion of turtles, but honestly that should go into a separate pull request. We can discuss and merge on Friday.