toybox-rs / Toybox

The Machine Learning Toybox for testing the behavior of autonomous agents.
http://toybox.rs
27 stars 12 forks source link

game_over() -> lives == 0? #91

Closed jjfiv closed 4 years ago

jjfiv commented 5 years ago

I seem to recall we're matching the atari_py on this one but it seems really counter-intuitive to my videogame-sense.

jjfiv commented 5 years ago

https://github.com/jjfiv/toybox/blob/d54afebde99e6d90afb68f8cca6d758846cebed3/ctoybox/toybox/toybox/toybox.py#L236-L237

Via #dev discussion: this is a baselines-ism and we want to kill it if possible -> should be done in our Envs but not in our Toybox objects.

etosch commented 4 years ago

I think this is currently true, no?