search

toymachiner62 / hapi-authorization

ACL plugin for hapijs
MIT License
80 stars 25 forks source link

Breaking change in 2.2.3 update from 2.2.2 - reverts to aclQuery siganture from 2.1.x #16

Closed jancervinka closed 8 years ago

jancervinka commented 8 years ago

I believe that you have an incorrect version in 2.2.3 tag. It contains the code of 2.1.x where aclQuery has a signature of function(parameter, cb). So if you update from 2.2.x (where the signature is function(parameter, request, cb)) to 2.2.3, the code breaks.

toymachiner62 commented 8 years ago

Can you point me to the function declaration you're specifically referring to?

NicolasRitouet commented 8 years ago

Indeed, the code contained in the 2.2.3 release seems to be old. The following line is not in the downloaded release: https://github.com/toymachiner62/hapi-authorization/blob/master/lib/index.js#L41

toymachiner62 commented 8 years ago

Ok i have no idea what I did to get myself screwed up that bad, but I think I have it working again with version 2.2.5. Please update from version 2.2.3 -> 2.2.5 and let me know if there's still any issues.