search

toymachiner62 / hapi-authorization

ACL plugin for hapijs
MIT License
80 stars 25 forks source link

hierarchy and rolehierarchy doesnt seems to be working in hapi v17 #26

Open tk120404 opened 5 years ago

tk120404 commented 5 years ago

In hapi v17, config are not getting bonded with settings

  server.bind({
    config: settings
  });

Due to which this.config.hierarchy is always coming as false

aquelatecnologia commented 4 years ago

@toymachiner62 i did a PR. It fail in 2 tests. I've add some comments to the pr about those TC, could you take a look ?

RicardoRdzG commented 4 years ago

I was about to report the same issue, @aquelatecnologia sent a pr to your repo to fix the failing test

emanuelecasadio commented 3 years ago

@toymachiner62 it's been almost 2 years since this bug has been reported. There is a PR that awaits your reply to fix this bug. It's quite a blocker for us, given that we can no longer use roles hierarchy.

toymachiner62 commented 3 years ago

@toymachiner62 it's been almost 2 years since this bug has been reported. There is a PR that awaits your reply to fix this bug. It's quite a blocker for us, given that we can no longer use roles hierarchy.

I honestly haven't used hapi.js in about 5-6 years. If someone wants to take over this repo i'm more than happy to let them as I don't have ample time to dedicate to this repo anymore.

RicardoRdzG commented 3 years ago

What needs to be done? I can do code reviews and maintenance. But I am no longer working with hapi either.

toymachiner62 commented 3 years ago

What needs to be done? I can do code reviews and maintenance. But I am no longer working with hapi either.

You're not working with hapi but it's a blocker for you?

RicardoRdzG commented 3 years ago

It was back in october 2019, but as anybody with access to source rolled my own version with the fix.