missing push button 2 for two player mode on Mega

toyoshim / iona

JVS IO Board by Arduino Nano

https://github.com/toyoshim/iona/wiki/Compatibility-Information

BSD 3-Clause "New" or "Revised" License

31 stars 11 forks source link

missing push button 2 for two player mode on Mega #13

Closed mikebrandt closed 2 years ago

mikebrandt commented 2 years ago

Hi, i tried to compile iona for Mega and i think that push button 2 for player 2 is missing in io def at line 117. Am i reading code wrong?

Best regards, Mike

toyoshim commented 2 years ago

I guess you meant line 177. This is just a source formatting issue. The service button isn't assigned for the player 2 (as same as player 1), and it results in that we have just 7 in(n, m) in the line. So, that should be fine. I will submit a format fix change.

toyoshim commented 2 years ago

https://github.com/toyoshim/iona/commit/65986f8bb2548e6de19828708844f9878198d156 Hope this CL explains better than my words above.