Redo the EGL window creation

[mv0]

This patch series includes the ability start up correctly as maximized/fullscreen from the beginning on the AGL platform.

Specifically this patch series:

• groups together agl-shell protocol requests in the EglWindow constructor
• makes part of the initial commit the set_toplevel request and the frame callback
• redoes the EGL window/surface creation to allow starting up as maximized/fullscreen
• paves the way to have regular applications starting up in various scenarios (compositor sending 0 values and apps need to chose a default value).

With these changes I get the gallery application running on both swrast (llvmpipe) and HW accelerated drivers.

LE: I've verified/tested this patch series on x86_64:

• Debian testing with gnome-shell/mutter 4.20
• Debian testing with weston main (post weston 10)
• Debian testing with AGL compositor master
• AGL platform (qemu x86_64) w/ a master from a few days ago (6 of May 2022). Together with https://gerrit.automotivelinux.org/gerrit/c/AGL/meta-agl/+/27460 (an unrelated change to this patch series) we get a boot-up to flutter gallery application.

[jwinarske]

Also please add what platforms you tested your PR on.

[mv0]

Also please add what platforms you tested your PR on.

Where I should add this? In the patch series? I do my tests/build on x86, as I don't have space to test out all platforms. The platforms are pretty irrelevant at this point, as we're not using anything specific to the AGL platforms. The compositor can run independently or various back-ends, but also locally, assuming you provide correct dependencies: wayland/wayland-protocols/weston are sufficient to build and run the AGL compositor.

Further more, with swrast we literally test out qemu viratualized without virgl/HW accelerated drivers, while running with GL renderer, we make use of the open source drivers, so rpi4 might fit here.

What I'd be interested if you want to have this working locally, on desktops. Haven't really tested out anything else than the AGL compositor, but I'll give it a try w/ gnome + weston.

[jwinarske]

@mv0 Just indicate in PR comments what platform it's tested on.

For Kirkstone the current CI platform list:

• AGL: qemu (x86_64), Renesas M3 (aarch64)
• Weston: RPI Zero 2W (aarch64)
• Gnome - Ubuntu 18-20 (x86_64)

For Dunell the CI platform list:

• AGL: qemu (x86_64), Renesas M3 (aarch64)
• NXP - Variscite Dart mxm8-mini (aarch64)
• NVidia Jetson Nano (aarch64)
• NVidia Jetson Xavier NX (aarch64)
• RPI3 32/64 (arm)
• RPI4 32/64 (aarch64)
• STM32MP15 (arm)
• Gnome - Ubuntu 18-20 (x86_64)
• Internal (aarch4)

The CI jobs and platform images are here: https://github.com/meta-flutter/meta-flutter

[mv0]

@mv0 Just indicate in PR comments what platform it's tested on.

For Kirkstone the current CI platform list:

• AGL: qemu (x86_64), Renesas M3 (aarch64)
• Weston: RPI Zero 2W (aarch64)
• Gnome - Ubuntu 18-20 (x86_64)

For Dunell the CI platform list:

• AGL: qemu (x86_64), Renesas M3 (aarch64)
• NXP - Variscite Dart mxm8-mini (aarch64)
• NVidia Jetson Nano (aarch64)
• NVidia Jetson Xavier NX (aarch64)
• RPI3 32/64 (arm)
• RPI4 32/64 (aarch64)
• STM32MP15 (arm)
• Gnome - Ubuntu 18-20 (x86_64)
• Internal (aarch4)

The CI jobs and platform images are here: https://github.com/meta-flutter/meta-flutter

Added all the platforms where I've verified/tested this patch series in the main PR.

[jwinarske]

@mv0 commits needs to be signed before they can be merged.

[mv0]

@mv0 commits needs to be signed before they can be merged.

Aren't they all Signed-off?

[jwinarske]

@mv0 hmm. GitHub is complaining about them not being signed. I see they are.