search

toyota-connected / ivi-homescreen

Embedded Flutter runtime targeting Embedded Linux with Wayland
Other
254 stars 35 forks source link

Minor parsing fixes for JSON configuration file #73

Closed mv0 closed 2 years ago

mv0 commented 2 years ago

This patch series fixes some minor parsing isssues I've found while using the JSON config file.

Specifically, app_id specified over the configuration is being ignored and found similar issue with debug_backend and disable_cursor.

jwinarske commented 2 years ago

updated README.md in main with backend_debug fix.

mv0 commented 2 years ago

Any reason for closing this PR?

jwinarske commented 2 years ago

@mv0

  1. Application id is global, and not unique per view. Only index 0 should be used, as it will go away with multi-display feature.
  2. if (cli.debug_backend != instance.debug_backend) is correct. If the value is different than stored, then assign it. The struct has a default value of false. So only if debug_backend is true will it be stored as such.
  3. I updated README.md in main with the typo.