toyota-connected / ivi-homescreen

Embedded Flutter runtime targeting Embedded Linux with Wayland
Other
254 stars 35 forks source link

Change Default Window Type #74

Closed jwinarske closed 2 years ago

jwinarske commented 2 years ago

-enables default window on AGL as Background prevents needing json config -harmless in desktop case, as it checks if agl_shell is not nullptr

mv0 commented 2 years ago

I think is is a mistake, defaulting to background surface role would make running ivi-homescreen impossible if running as as simple application.

With this change we basically break functionality.

This seems pretty backwards to provide an argument to use default values.

jwinarske commented 2 years ago

@mv0 This is required to enable using CLI to run application on AGL without requiring --j= option. The fix will be to add CLI option to select window type.

https://github.com/toyota-connected/ivi-homescreen/pull/76