search

toystars / react-native-multiple-select

Simple multi-select component for react-native
MIT License
566 stars 315 forks source link

added functionality to hide selected items to be shown in List #103

Closed jbbpatel94 closed 5 years ago

jbbpatel94 commented 5 years ago

added functionality to hide selected items to be shown in List

AugustoAleGon commented 5 years ago

@jbbpatel94 I like this functionality. Let test it today and if everything goes good I will accept it.

jbbpatel94 commented 5 years ago

@jbbpatel94 I like this functionality. Let test it today and if everything goes good I will accept it. Sure, If you have any changes or suggestion, let me know.

AugustoAleGon commented 5 years ago

@jbbpatel94 https://github.com/AugustoAleGon/react-native-multiple-select-sample I am testing your branch, It is not working for me. Can please check?

jbbpatel94 commented 5 years ago

@jbbpatel94 https://github.com/AugustoAleGon/react-native-multiple-select-sample I am testing your branch, It is not working for me. Can please check?

I updated and now, It's working fine.

AugustoAleGon commented 5 years ago

@jbbpatel94 can you please update your PR? The latest changes are not included here. I will accept and release the new version.

jbbpatel94 commented 5 years ago

@jbbpatel94 can you please update your PR? The latest changes are not included here. I will accept and release the new version.

done

jbbpatel94 commented 5 years ago

https://github.com/jbbpatel94/react-native-multiple-select/tree/patch-1 <http://this one> this one

On Wed, Jul 10, 2019 at 9:17 PM Augusto Gonzalez notifications@github.com wrote:

@jbbpatel94 https://github.com/jbbpatel94 is this commit there? jbbpatel94@82c28b0 https://github.com/jbbpatel94/react-native-multiple-select/commit/82c28b0589b6c07cf98f9a2feb6beff2059e008e I don't see it in the changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/toystars/react-native-multiple-select/pull/103?email_source=notifications&email_token=AFMOGN7KRIGVVA32GKN6MITP6YACVA5CNFSM4H32YANKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZT4URA#issuecomment-510118468, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMOGNZT4ZWQU7VDIPRLJILP6YACVANCNFSM4H32YANA .

-- Thanks Jaisa Ram 9660798468