toystars / react-native-multiple-select

Simple multi-select component for react-native
MIT License
566 stars 315 forks source link

Update displayed selected items to handle odd font sizes #106

Closed crcnum4 closed 1 year ago

crcnum4 commented 5 years ago

updated the _displaySelected items as if the selected items text are all capped letters or include characters that take up more then 8 pixels width the displayed items will cut the text short after only a few characters. example: CS100 and CS500 were both cut off.

updated the selected items to be more dynamic removing the static width attribute from the view. The text field does not require the flex 1 as the text component will provide a width depending on the content inside it. added a margin right to provide spacing for the X tests show that the wrapping still occurs correctly. Displayed items now always display the text regardless of font type or character width.

also updated the contributors.md since this is my second pull request. I can remove that if I haven't contributed enough yet.

(no features changed so no edits to the readme)

crcnum4 commented 5 years ago

oops there seems to be some pulls i need to make. i'll correct that

crcnum4 commented 5 years ago

took care of the merge conflicts good to go now still works