search

toystars / react-native-multiple-select

Simple multi-select component for react-native
MIT License
566 stars 315 forks source link

I think that lodash must be removed #20

Open camux opened 7 years ago

camux commented 7 years ago

Here reason

https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore

mikaello commented 7 years ago

Three functions from lodash is used in this module: reject, find and get.

find is the only one mentioned in your link. Maybe you could give examples of how reject and get could be replaced in pure JS?

reject in this module: https://github.com/toystars/react-native-multiple-select/blob/fe161d9bf97310216c70694714f90c36c6431023/lib/react-native-multi-select.js#L175-L177 https://github.com/toystars/react-native-multiple-select/blob/fe161d9bf97310216c70694714f90c36c6431023/lib/react-native-multi-select.js#L225-L227

get in this module: https://github.com/toystars/react-native-multiple-select/blob/fe161d9bf97310216c70694714f90c36c6431023/lib/react-native-multi-select.js#L113 https://github.com/toystars/react-native-multiple-select/blob/fe161d9bf97310216c70694714f90c36c6431023/lib/react-native-multi-select.js#L302-L304