search

tozny / java-aes-crypto

A simple Android class for encrypting & decrypting strings, aiming to avoid the classic mistakes that most such classes suffer from.
http://tozny.com/blog/encrypting-strings-in-android-lets-make-better-mistakes/
MIT License
738 stars 224 forks source link

request: java jre/jdk specific version #35

Open spyhunter99 opened 7 years ago

spyhunter99 commented 7 years ago

Would it be possible to get a java specific version of this?

Also it would be worth testing something encrypted on jre could be decrypted from adk and vs versa

spyhunter99 commented 7 years ago

I was able to hack up the code a bit to make it work on jre/jdk, however it needs some additional checks for windows based operating systems or anything that does not have a /dev/urandom. I'm not sure what effect it has by disabling the method "installLinuxPRNGSecureRandom" in terms of crypto stength

SyntaxPolice commented 7 years ago

Thanks! That installLinuxPRNG function will have no effect on anything but certain Android versions. Did you create a pure Java branch by chance?

thanks,

isaac

On Tue, Jan 31, 2017 at 7:15 AM, spyhunter99 notifications@github.com wrote:

I was able to hack up the code a bit to make it work on jre/jdk, however it needs some additional checks for windows based operating systems or anything that does not have a /dev/urandom. I'm not sure what effect it has by disabling the method "installLinuxPRNGSecureRandom" in terms of crypto stength

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tozny/java-aes-crypto/issues/35#issuecomment-276390569, or mute the thread https://github.com/notifications/unsubscribe-auth/AAieUw5W3Osfge1uaCs2Lr5f9ot77S5Jks5rX0_9gaJpZM4Lyvd3 .

spyhunter99 commented 7 years ago

I can do that perhaps later tonight. The change set is pretty small

spyhunter99 commented 7 years ago

PR opened

ericmann commented 7 years ago

Thanks for the PR. We'll get to reviewing things soon as we can 👍