Refactor msp430/x2xxx/usci to enable SPI on USCI A - Githubissues

tp-freeforall / prod

TinyOS (less academic, more industrial, rD, less filling), still a floor wax

BSD 3-Clause "New" or "Revised" License

82 stars 37 forks source link

Refactor msp430/x2xxx/usci to enable SPI on USCI A #29

Closed tgtakaoka closed 6 years ago

tgtakaoka commented 6 years ago

The idea behind this refactoring is splitting HplMsp430UsciA and HplMsp430UsciB interfaces into four function specific interfaces.

HplMsp430Usci: common USCI HPL of A and B.
HplMsp430UsciSpi: SPI specific USCI HPL shared between A and B.
HplMsp430UsciUart: UART specific USCI HPL for A.
HplMsp430UsciI2C: I2C specific USCI HPL for B.

This is just interfaces and configurations change and contains no logical difference.

tgtakaoka commented 6 years ago

This pull request addresses issue#28.

cire831 commented 6 years ago

does this close issue #28?

tgtakaoka commented 6 years ago

Yes, I think so.

I confirmed that configuring SPI on USCI A0, A1, B0, B1 of msp430f2617 are compiled without error, though I didn't confirm an actual SPI functionarilty.

cire831 commented 6 years ago

do you have access to any msp4302618 or similar development boards from TI?

that is one of the x2 family processors.

tgtakaoka commented 6 years ago

I have raw msp430f2618 chip ready on breadboard in hand. I'll check SPI functionality when I find spare time. img_20180527_170514

cire831 commented 6 years ago

sound good. thanks.

the approarch to the seperation looks similar to what I did on the x5 and on the msp432 code. looks good.

tgtakaoka commented 6 years ago

Sorry for the delay, but I finally found a time to confirm. SPI functionality on USCI A0, A1, B0, B1 work fine on MSP430F2618.

Please have an another look. Thanks.