search

tp / tsaga

Typesafe and lightweight way to write Redux-connected functions with asynchronous side-effects that are easily testable.
Apache License 2.0
8 stars 1 forks source link

Henri's changes #10

Closed tp closed 5 years ago

tp commented 5 years ago

@HenriBeck When you have some time this week, let's sit together and discuss what we should merge here. I guess for starters 1 test helper should be sufficient (currently we have 3 separate once).

Also I'd like to revisit the env issue. The current approach with the many properties in each env makes it simple to write the implementation and test helpers, but the application code looked much nicer in the few hours where had just 3.

I think fork is still something special to take care of (as it requires a new env / cancellation token), but I guess there is also a nicer way to do this, without cluttering the default use.

HenriBeck commented 5 years ago

Sounds good. Can you close the PR, I will break up the changes in different PRs.

I won't be in the office until Friday again.