Closed tp closed 5 years ago
Ideas: Either we explicitly rely on jest as a peerDependency
, or we just use the underlying comparison functions and eschew a dependency on the rest of jest.
I think we can use the expect library.
Though I don’t know how expect
behaves with ava for example.
Oh, missed that because we also use
deepStrictEqual
in the old test helper.Hmm, let's see, does
expect
have a much better output? Otherwise I would suggest switching todeepStrictEqual
. (Ifexpect
is better, maybe we can use the underlying library directly, and skip a fulljest
dependency.)This seems really bad overall though, since the only reason why it's working is that we by accident also use
jest
as a test runner and that then provides the global expect.I wonder how that even works, because we don't have
jest
in thetsconfig.json
(unlike the AYSA apps, which do have that IIRC)._Originally posted by @tp in https://github.com/tp/tsaga/pull/49/review_comment/create_