search

tp / tsaga

Typesafe and lightweight way to write Redux-connected functions with asynchronous side-effects that are easily testable.
Apache License 2.0
8 stars 1 forks source link

Move whenCalledWith closer to `expectBoundFunction` #53

Closed tp closed 5 years ago

tp commented 5 years ago

Sounds good, let's do the change in a different PR though

Originally posted by @HenriBeck in https://github.com/tp/tsaga/diffs

tp commented 5 years ago

@HenriBeck I'd like to tackle this over the weekend to stay familiar with the code base.

HenriBeck commented 5 years ago

@tp any news on this? We will start with tsaga now and I would like to start using the ”final” testing implementation then to not introduce another change in a few weeks

tp commented 5 years ago

@HenriBeck Sorry, didn't get to it yet (who would've thought that 2 20 minute tasks are too much to take…). But I'll do it right now :)

tp commented 5 years ago

@HenriBeck Your approach of overlaying the interface on top of the implementation is very nice. Just have to shuffle a few interfaces instead of having to mess with lots of implementation code 🎉