search

tp / tsaga

Typesafe and lightweight way to write Redux-connected functions with asynchronous side-effects that are easily testable.
Apache License 2.0
8 stars 1 forks source link

Compare full state by default, allow partial comparisons #54

Open tp opened 5 years ago

tp commented 5 years ago

This slipped by me before, probably because we weren't making use of it in the "real" tests so far.

What do you think about having 2 possible functions here e.g. toHaveFinalState and toPartiallyHaveFinalState. Or as suggested in the other PR support a map ("lense") function to "zoom in"?

_Originally posted by @tp in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMTcwMTYxNTA5OnYy/pull_request_review_threads/discussion_

tp commented 5 years ago

@HenriBeck I'd like to tackle this over the weekend to stay familiar with the code base :)

HenriBeck commented 5 years ago

I would go with toHaveFinalState and toPartiallyHaveFinalState just because I think you need to have less knowledge about the library to understand these.