search

tpapp / Fretboards.jl

Julia package for visualizing chords on the guitar fretboard.
Other
6 stars 1 forks source link

Transferring to JuliaMusic #1

Open aminya opened 4 years ago

aminya commented 4 years ago

It would be good to transfer this repository to JuliaMusic. I was going to make a package that does this. I am happy that it is already created 🎸

Here is the issue I had in MusicXML https://github.com/JuliaMusic/MusicXML.jl/issues/4

I developed AcuteML.jl.

Then I used it inside MusicXML.jl. I planned to use AcuteML and plot fretboards using Html or PyCall.

Here is the issue in MusicVisualizations.jl https://github.com/JuliaMusic/MusicVisualizations.jl/issues/1

tpapp commented 4 years ago

I am open to the idea, let's revisit this issue when I have a working prototype.

aminya commented 4 years ago

Sure. But for example, the code in notes.jl can be moved either to Midi.jl or MusicXML.jl. We already have a Note type https://github.com/JuliaMusic/MIDI.jl/blob/cf99e27a519ccbbf729c6ca078a8fed94a6137e5/src/note.jl#L7 and a NoteX type https://github.com/JuliaMusic/MusicXML.jl/blob/0356abcf3bc18efc534506844cb3c5843d079b5d/src/MusicXML.jl#L462

For Fretboards.jl I think MusicXml is a better place. I planned to add Guitar tab support. https://www.musicxml.com/tutorial/tablature/fret-and-string/

tpapp commented 3 years ago

I recently refactored and simplified the code, realizing that what I called a note is better described as a pitch. Both the Note and NoteX types mentioned above do much more, so I am not sure what the benefit of using them would be for this package.