search

tpapp / LogDensityProblemsAD.jl

AD backends for LogDensityProblems.jl.
MIT License
12 stars 6 forks source link

Fix chunk normalization. #14

Closed tpapp closed 1 year ago

tpapp commented 1 year ago

Integers did not work, as they were passed directly. Now normalize earlier. Minor changes to function names.

tpapp commented 1 year ago

Sure, it what did not work was eg ADgradient(:ForwardDiff, l; chunk = 5); I added a test.

tpapp commented 1 year ago

I think it is better to resolve to a type early, while constant folding has a chance to catch this. Thanks for the review, sorry the description was not clear.