Closed ptiede closed 1 month ago
After talking with @wsmoses I'm going to move some of the set_primal stuff into EnzymeCore
@ptiede: thanks! so should we wait for some other change, or merge if tests pass?
FWIW, currently 1.9 can't satisfy version requirements, but I am happy to drop Julia 1.9 if @devmotion agrees. Users of 1.9 can still install earlier versions of the package.
@devmotion I've updated the PR to utilize Enzyme's new WithPrimal
feature. Let me know if you would prefer to continue to support 1.9. If so, I can the branches.
FWIW, I would go for the simple solution and drop 1.9.
No problem! Let me know if you need anything else!
@devmotion: OK if we merge this?
The Enzyme Ext for Enzyme version 0.13 is currently incorrect. A number of things changed that makes the current version on main incorrect including
In addition if you need runtime activity you now need to pass
<:ReverseMode{true}
. The EnzymeExt on main will drop this and always go withReverseMode{false}
.This PR tries to fix all of these issues by
logdensity_and_gradient