search

tpapp / PkgSkeleton.jl

Generate Julia package skeletons using a simple template system
Other
51 stars 7 forks source link

dont spawn new process for Pkg #17

Closed 00vareladavid closed 3 years ago

00vareladavid commented 4 years ago

First, nice package! I appreciate the minimalism.

I noticed PkgSkeleton was slower than expected when generating multiple repos at once. This avoids the cost of spawning a new process and of unnecessary registry updates.

codecov[bot] commented 4 years ago

Codecov Report

Merging #17 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          47     52    +5     
=====================================
+ Hits           47     52    +5
Impacted Files Coverage Δ
src/PkgSkeleton.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c1b22b...a90615d. Read the comment docs.

tpapp commented 4 years ago

Thanks for the PR, and sorry for the delay in review, I try to do these things in batches.

My only concern is that setting Base.ACTIVE_PROJECT[] is not exposed API.

tpapp commented 3 years ago

I merged this but got into a git mess, so closing the PR.