search

tpapp / TransformVariables.jl

Transformations to contrained variables from ℝⁿ.
Other
66 stars 14 forks source link

Update scalar.jl to use muladd #102

Closed ptiede closed 1 year ago

ptiede commented 1 year ago

This updates scalar.jl to use muladd generically for ScaledShiftedLogistic since https://github.com/JuliaDiff/DiffRules.jl/issues/28 has been merged. I also used muladd instead of fma since it only uses fma if it does give a speed boost. Additionally, I was having issues using Enzyme.jl with fma inserted while everything seems to work fine with muladd.

ptiede commented 1 year ago

The errors seems to be from ADgradient not being defined. Is that some versioning issue with LogDensityProblems?

tpapp commented 1 year ago

ptiede/TransformVariables.jl#1 should fix CI.

tpapp commented 1 year ago

Sorry, it was closed accidentally.

ptiede commented 1 year ago

Sorry for the delay! Holidays happened, and I got stuck with a recent Enzyme bug that just got fixed. Did you want me to add an additional test in another PR?

tpapp commented 1 year ago

It is fine as it is, but of course tests are always welcome if you have time. Thanks again for the PR.