Closed chriselrod closed 2 years ago
Thanks!
I am perfectly fine with giving up on any versions below Julia 1.6 if that makes the code simpler, so feel free to just bump compat versions and the lowest CI version and remove the conditionality in tests.
I'll suggest that we more forward with the current version and wait with restricting the supported versions until strictly required. The package still works with older versions and no worse with this PR than before. This is just a performance improvement for more recent versions.
I'm okay either way. May be worth testing the fix here on 1.6 as well (I haven't tried on 1.6, so I am not sure it'll work there).
Thanks, will merge as is. Strictly speaking allocations or inference failures are not considered bugs from my perspective outside the latest released version and LTS.
The added test will fail on the current master and the latest release. On 0.6.1, I get: