tpapp / julia-repl

Run an inferior Julia REPL in a terminal inside Emacs
Other
169 stars 35 forks source link

`julia-repl-includet-buffer` command should also send `using Revise` #134

Closed isentropic closed 5 months ago

isentropic commented 1 year ago

When reporting an issue, please provide

  1. the Emacs version (M-x emacs-version [RET], will also appear in the buffer *Messages*), GNU Emacs 28.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-11-07
  2. the Julia version (VERSION) 1.8.3
  3. the version of julia-repl (something like “latest master” is fine). Irrelevant
  4. self-contained steps to replicate the issue.

Perhaps when trying to includet the buffer revise should be pulled up automatically the it currently is Vscode. Perhaps no need to install, the user could do that themselves. Just sending the command should be enough.

isentropic commented 1 year ago

Perhaps just adding a line here would be enough, if it is I could send a PR. Let me know

JHonaker commented 1 year ago

I don't see any reason why changing that first string in (concat "Revise.includet(\"" to (concat "using Revise; Revise.includet(\"" wouldn't work. In fact, I did just that in my config, and I haven't had any issues.

isentropic commented 1 year ago

I opened a basic PR for this https://github.com/tpapp/julia-repl/pull/138 Feel free either to merge it or just add this minor change yourself directly