search

tpapp / julia-repl

Run an inferior Julia REPL in a terminal inside Emacs
Other
169 stars 35 forks source link

Warning in Emacs 29 related with `buffer-local-value` #136

Closed ronisbr closed 1 year ago

ronisbr commented 1 year ago

When opening julia-repl in Emacs 29, I get the following warning:

~/.emacs.d/.local/straight/build-29.0.60/julia-repl/julia-repl.el: Warning:
    ‘buffer-local-value’ is an obsolete generalized variable.
tpapp commented 1 year ago

Thanks, I have no clue what changed in 29, but asked here.

ronisbr commented 1 year ago

I asked for help in IRC channel, and I was told to replace with the following:

(with-current-buffer BUFFER (sets-local VAR VAL))

Makes sense?

ronisbr commented 1 year ago

I just notice two more warnings:

../../../../.emacs.d/.local/straight/build-29.0.60/julia-repl/julia-repl.el: Warning: Case 'ansi-term will match ‘quote’.  If that’s intended, write (ansi-term quote) instead.  Otherwise, don’t quote ‘ansi-term’.
../../../../.emacs.d/.local/straight/build-29.0.60/julia-repl/julia-repl.el: Warning: Case 'vterm will match ‘quote’.  If that’s intended, write (vterm quote) instead.  Otherwise, don’t quote ‘vterm’.
tpapp commented 1 year ago

Thanks for asking on IRC, and for the other two warnings. I made a PR.

ronisbr commented 1 year ago

Thanks @tpapp !! I will test tonight and will provide you with some feedback.

ronisbr commented 1 year ago

All the warnings are gone! Thanks! I will submit a PR to doom-emacs updating this mode and Julia-mode.