Open steffenhaug opened 1 year ago
Yes, that form returns nil
.
The intention is that functions run in julia-repl-hook
just use the current buffer, and it should be ensured that it is a valid buffer. Hooks should not call julia-repl-inferior-buffer
at all.
I clarified this, does 9503ef7 address your question?
Yes, that makes sense. Thank you!
Emacs version 28.2, Julia version 1.9. Issue still in latest master.
https://github.com/tpapp/julia-repl/blob/57a15dfafed680ad7d81f779d414e8cb6717417c/julia-repl.el#L146-L152
I'm not awfully familiar with Emacs, so feel free to correct me if this is not a bug. I don't understand why the
(when ...)
form is in the else-branch of theif-let
. I think this makes the function as a whole always returnnil
, and my particular issue is that this causes infinite recursion in hooks onjulia-repl-hook
that callsjulia-repl-inferior-buffer
, as said function will always take the branch for creating a new buffer (which runs the hooks again).I assume the intention is for these forms to run sequentially? I fixed this by moving the form into the
with-current-buffer
-form, but as I'm not very proficient I don't know if there are any bad side effects of this, maybe aprogn
would be better.