search

tpapp / julia-repl

Run an inferior Julia REPL in a terminal inside Emacs
Other
168 stars 35 forks source link

Create minor mode for julia-repl #30

Open non-Jedi opened 6 years ago

non-Jedi commented 6 years ago

If a buffer gets created by e.g. julia-repl-send-line, that buffer doesn't have the julia-repl-mode minor mode defined here. Is that an oversight, or am I misunderstanding how emacs minor modes should work (very possible; I'm still quite emacs noobish)?

non-Jedi commented 6 years ago

Ftr, I'm currently working around this by adding julia-repl-mode to julia-repl-hooks which seems less than ideal.

tpapp commented 6 years ago

The julia-repl-mode is a minor mode for Julia source code files (.jl). julia-repl.el does not define a minor mode for the inferior buffer.

Would one be useful for you?

non-Jedi commented 6 years ago

Ah. I see. Yes it would be, but thanks to julia-repl-hooks I can at least work around it.

Spacemacs keybinding config system works per-mode rather than per-buffer.

EDIT: turning the julia-repl function into a minor mode doesn't look like it'd be all that difficult. I may take a shot at a PR for such if I get time in the next few weeks.