CL function use without explicit (REQUIRE 'CL)

tpapp / julia-repl

Run an inferior Julia REPL in a terminal inside Emacs

Other

170 stars 35 forks source link

CL function use without explicit (REQUIRE 'CL) #56

Closed pand5461 closed 5 years ago

pand5461 commented 5 years ago

The function definitions for first, second, incf and stable-sort are void unless (require 'cl) is used.

The CL package is loaded by Julia-mode, but when it is not used, the REPL does not start.

tpapp commented 5 years ago

Good catch, will fix. Thanks!

tpapp commented 5 years ago

I spoke to soon: apparently we already

(require 'cl-lib)

which should take care of this, and is AFAIK the preferred approach.

This would work for everything above Emacs 24.3. Which version are you using?

pand5461 commented 5 years ago

Emacs 26.1.

cl-lib provides the names with the cl- prefix. Thus, the names must be cl-first etc.

tpapp commented 5 years ago

@pand5461: Thanks, I prefixed everything I suspected with cl- in #57, but if you have a systematic way of triggering any remaining errors, please let me know if I missed any.

pand5461 commented 5 years ago

Calling (byte-compile-file "julia-repl.el") from emacs --no-init-file produces no warnings. I guess, that means there are no implicit dependencies now. Thanks!