search

tpapp / julia-repl

Run an inferior Julia REPL in a terminal inside Emacs
Other
170 stars 35 forks source link

Add option to save buffer on send #70

Closed antoine-levitt closed 5 years ago

antoine-levitt commented 5 years ago

ESS does this without asking, which I find more convenient (when I want to send a buffer, I want to save it first). I think it's the most appropriate behavior but I appreciate others might find that dangerous, so I've left disabled by default; if you feel it's OK I can toggle it on.

tpapp commented 5 years ago

Thanks for the PR, I think this makes a lot of sense.

Since you did not branch from latest master, can you please merge that to your branch, and then make the same change for the other application of save-buffer, julia-repl-includet-buffer?

antoine-levitt commented 5 years ago

Done (and for the first time, I actually managed to do a rebase on a git branch without screwing everything up, I'm so happy)

tpapp commented 5 years ago

Thanks for the nice work, merging.