search

tpapp / lla

Lisp Linear Algebra
Boost Software License 1.0
90 stars 17 forks source link

Incorrect Assert in Least-Squares-QR? #13

Closed srt19170 closed 10 years ago

srt19170 commented 10 years ago

Should the assert in Least-Squares-QR be

(assert (plusp df) () 'not-enough-columns)

or 

(assert (not (minusp df)) () 'not-enough-columns)

I admit to being a novice, but it seems like a square matrix should be acceptable?

tpapp commented 10 years ago

Thanks, fixed in 3b8a0e0.