tpapp / lla

Lisp Linear Algebra
Boost Software License 1.0
90 stars 17 forks source link

Undefined Type LLA::MATRIX in LLA::LEAST-SQUARES-QR #14

Closed srt19170 closed 10 years ago

srt19170 commented 10 years ago

When using LLA::Least-Squares-QR, I get an undefined type error on LLA::MATRIX. (This is using SBCL). Changing the line

   (make-instance 'qr :qr qr)

to just qr eliminates the error.

tpapp commented 10 years ago

Are you sure you are using the latest LLA from the repo? This seems to be already fixed. If you still have the error, please provide a self-contained example.

srt19170 commented 10 years ago

When I tried to upgrade to the latest LLA from the repo with SBCL, I get the following errors:

; file: C:/Users/Dad/quicklisp/local-projects/lla-20140308-git/src/conditions.lisp
; in: DEFINE-CONDITION LLA-INTERNAL-ERROR
;     (FORMAT STREAM "~A~&This is a bug in LLA, please see the README~
;                                on how to report it."
;             (SLOT-VALUE CONDITION 'LLA::MESSAGE))
; 
; caught ERROR:
;   during macroexpansion of
;   (FORMATTER "~A~&This is a bug in LLA, please see the README~
;                                on how to report it.").
;   Use *BREAK-ON-SIGNALS* to intercept.
;   
;    error in FORMAT: unknown directive (character: Return)

After fixing those errors, I get the following error (multiple times) in linear-algebra.lisp:

; caught ERROR:
;   (during macroexpansion of (SB-PCL::%DEFMETHOD-EXPANDER MM ...))
;   The value +INTEGER+ is not of type (MOD 5).

I'm not sure what to do about those.

I'm guess this is why the Quicklisp version is out of date.

tpapp commented 10 years ago

Oops, forgot to merge, should be fixed now. I will investigate the quicklisp version and get back to you. Please be so kind as to test the latest version in the repo.

srt19170 commented 10 years ago

The merge fixed the type error issue, but SBCL still doesn't like your ~^M in format strings. Maybe this is a Windows versus Linux problem? The error message shows up as "~^M" and for Windows the newline character should be ^J?

tpapp commented 10 years ago

Please open another issue about that with a self-contained example.