tpaviot / ProcessScheduler

A Python package for automatic and optimized resource scheduling
https://processscheduler.github.io/
GNU General Public License v3.0
59 stars 19 forks source link

Preliminary work for JSON import/export (Sourcery refactored) #103

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #102 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the json-import-export branch, then run:

git fetch origin sourcery/json-import-export
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 1.42 ⭐ 1.42 ⭐ 0.00
Method Length 21.93 ⭐ 21.86 ⭐ -0.07 👍
Working memory 4.56 ⭐ 4.56 ⭐ 0.00
Quality 90.63% 90.65% 0.02% 👍
Other metrics Before After Change
Lines 109 109 0
Changed files Quality Before Quality After Quality Change
processscheduler/context.py 90.63% ⭐ 90.65% ⭐ 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov-commenter commented 3 years ago

Codecov Report

Merging #103 (aa3dac3) into json-import-export (33c9615) will increase coverage by 0.00%. The diff coverage is 85.71%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           json-import-export     #103   +/-   ##
===================================================
  Coverage               95.48%   95.49%           
===================================================
  Files                      38       38           
  Lines                    4009     3993   -16     
===================================================
- Hits                     3828     3813   -15     
+ Misses                    181      180    -1     
Impacted Files Coverage Δ
processscheduler/json_io.py 95.94% <83.33%> (+0.39%) :arrow_up:
processscheduler/context.py 87.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33c9615...aa3dac3. Read the comment docs.