Preliminary work for JSON import/export (Sourcery refactored)

[sourcery-ai[bot]]

Pull Request #102 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the json-import-export branch, then run:

git fetch origin sourcery/json-import-export
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai[bot]]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.03%.

Quality metrics	Before	After	Change
Complexity	1.62 ⭐	1.90 ⭐	0.28 👎
Method Length	23.89 ⭐	21.89 ⭐	-2.00 👍
Working memory	3.84 ⭐	3.55 ⭐	-0.29 👍
Quality	92.98% ⭐	92.95% ⭐	-0.03% 👎

Other metrics	Before	After	Change
Lines	113	107	-6

Changed files	Quality Before	Quality After	Quality Change
processscheduler/first_order_logic.py	92.98% ⭐	92.95% ⭐	-0.03% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov-commenter]

Codecov Report

Merging #105 (0d5255f) into json-import-export (d307260) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           json-import-export     #105      +/-   ##
======================================================
- Coverage               95.57%   95.56%   -0.01%     
======================================================
  Files                      38       38              
  Lines                    4065     4059       -6     
======================================================
- Hits                     3885     3879       -6     
  Misses                    180      180              

Impacted Files	Coverage Δ
processscheduler/first_order_logic.py	97.29% <100.00%> (-0.38%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d307260...0d5255f. Read the comment docs.