Closed dreinon closed 3 years ago
Great, did you use a linter?
Yes, I did automatically. I try not to modify style if I have to change just a bit of code, but if I modify enough code, linter + formatter help me with readability and error preventing.
I use vscode as editor, with flake8 linting (this doesn't format code, just reports errors in code and in style) and autopep8 formatter (this does modify code). Both format my code style as PEP guide states (or at least, almost :smile:) Vscode python extension has itself a linter called Pylance, which is also very good, and which I also use. Something to note is that PEP says that max line length should be 79, which I don't like much, and I'm using 130.
In addition, I set some precommit hooks to achieve what formatter doesn't. Between all I use, I think the following would be interesting for this project:
If you want, review my PR whenever you have time and after closing them, I can make a PR with my code style proposal.
This is a too big commit only for a small fix. I suggest splitting the fix and the coding style changes into two different PR. It will be easier to review
Ok, I agree this PR is not so accurate. I'll review it later, close this and open a new one.
Great, did you use a linter?