search

tpaviot / ProcessScheduler

A Python package for automatic and optimized resource scheduling
https://processscheduler.github.io/
GNU General Public License v3.0
59 stars 17 forks source link

Update doc #75

Closed dreinon closed 3 years ago

dreinon commented 3 years ago

Solving still left to review.

tpaviot commented 3 years ago

The not_ change has to be propagated to the related unit tests. I'm updating the solver doc in the meantime

dreinon commented 3 years ago

Right, forgot to do that.

I'll do it later

tpaviot commented 3 years ago

Solving reviewed.

Can you please rebase your branch on top of update-doc?

dreinon commented 3 years ago

Sure

codecov-commenter commented 3 years ago

Codecov Report

Merging #75 (7de69bd) into update-doc (17ed969) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           update-doc      #75   +/-   ##
===========================================
  Coverage       94.94%   94.94%           
===========================================
  Files              30       30           
  Lines            3403     3403           
===========================================
  Hits             3231     3231           
  Misses            172      172
Impacted Files Coverage Δ
processscheduler/first_order_logic.py 97.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17ed969...7de69bd. Read the comment docs.

dreinon commented 3 years ago

Have I rebased correctly?

tpaviot commented 3 years ago

@dreinon yep, rebase successful. Did you fix the tests?

dreinon commented 3 years ago

yes, I fixed my fix of not not operator, since I had done it wrong. After that, tests passed.

tpaviot commented 3 years ago

👍